json: fix cycle detection #153
Open
+182
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extemporalgenome
force-pushed
the
kgillette/2025-07/fix-cycle-detection
branch
from
0c1b278 to
e7e3ee1
Compare
This is necessary for cycle detection to work, which had been implemented, yet was broken. Also introduce cachedCodec helper function.
Also set UnsupportedValueError.Value (better stdlib compat).
extemporalgenome
force-pushed
the
kgillette/2025-07/fix-cycle-detection
branch
3 times, most recently
from
657600e to
722d2e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cycle detection had been implemented, but was non-functional due to a call-chain subtlety.
This also expands cycle detection to cover maps and slices, as the stdlib implementation covers these cases as well.